-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce startup time for System Bridge integration #91171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
integration: system_bridge
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: silver
labels
Apr 10, 2023
timmo001
force-pushed
the
system-bridge-startup
branch
from
April 10, 2023 14:52
aaa67e5
to
a6a3ee0
Compare
balloob
reviewed
Apr 11, 2023
They are required to initialise dynamic sensors
timmo001
force-pushed
the
system-bridge-startup
branch
from
April 12, 2023 17:03
ac3c3a4
to
4760c8a
Compare
frenck
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @timmo001 👍
../Frenck
balloob
pushed a commit
that referenced
this pull request
Apr 13, 2023
Merged
tkhadimullin
pushed a commit
to tkhadimullin/ha-core
that referenced
this pull request
Apr 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cherry-picked
cla-signed
code-quality
integration: system_bridge
Quality Scale: silver
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds missing timeout and decreases timeout time for initialisation of System Bridge. Issue is caused by offline devices failing to connect causing initilisation to fail.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: