New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add broadlink climate #91183
Add broadlink climate #91183
Conversation
Hey there @Danielhiversen, @felipediel, @L-I-Am, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Thank you for your feedback @fustom. I implemented the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tested a little bit and unfortunately there is an error:
We need to check the state is in a HVACMode. I think the following change should solve the problem. UPDATE: Doesn't work with HA StrEnum!
This should work: if old_state.state in [mode.value for mode in HVACMode]:
self._attr_hvac_mode = old_state.state Maybe we need to do the same with HVACAction. |
258a366
to
c7f0788
Compare
8e8e3cb
to
8bd7967
Compare
8bd7967
to
9d40b0f
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
5eef3f5
to
77d2993
Compare
77d2993
to
b97d561
Compare
Looks good. If the code is working, I think it's ready to be merged. |
d975682
to
e5883b0
Compare
e5883b0
to
0b3cc51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eifinger 👍
Proposed change
This is an attempt to revive #61681
This PR adds the capability to control thermostats with the broadlink integration.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: