Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xknx to 2.9.0 #91282

Merged
merged 4 commits into from
Apr 22, 2023
Merged

Update xknx to 2.9.0 #91282

merged 4 commits into from
Apr 22, 2023

Conversation

farmio
Copy link
Contributor

@farmio farmio commented Apr 12, 2023

Proposed change

Update xknx to 2.9.0 (from 2.7.0)

https://github.com/XKNX/xknx/releases/tag/2.8.0
https://github.com/XKNX/xknx/releases/tag/2.9.0

Some xknx internal method signatures, used in HA, have been changed in this release. These require changes in __init__.py and schema.py.
Added tests for these changed validators as they were not tested previously.

Also the xknx internal address validator is now used in config_flow.py which allows to pass hostnames and interface names directly (but most users probably use auto-discovery anyway). The IP addresses were saved as stings before, so apart from using the validator and amending strings.json there is nothing else to do 😃

In 2.9.0 asyncio.wait_for is replaces by asyncio.timeout.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck
Copy link
Member

frenck commented Apr 12, 2023

Needs #91295

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Apr 12, 2023
@farmio farmio changed the title Update xknx to 2.8.0 Update xknx to 2.9.0 Apr 22, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @farmio 👍

../Frenck

@frenck frenck merged commit 95d44e1 into home-assistant:dev Apr 22, 2023
@farmio farmio deleted the xknx-2.8.0 branch April 22, 2023 16:36
joanwa pushed a commit to joanwa/home-assistant that referenced this pull request Apr 23, 2023
* Update xknx to 2.8.0

* add tests for validators

* Update strings.json

* Update xknx to 2.9.0
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants