-
-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xknx to 2.9.0 #91282
Merged
Merged
Update xknx to 2.9.0 #91282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Needs #91295 |
frenck
approved these changes
Apr 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @farmio 👍
../Frenck
joanwa
pushed a commit
to joanwa/home-assistant
that referenced
this pull request
Apr 23, 2023
* Update xknx to 2.8.0 * add tests for validators * Update strings.json * Update xknx to 2.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
dependency
integration: knx
Quality Scale: platinum
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update xknx to 2.9.0 (from 2.7.0)
https://github.com/XKNX/xknx/releases/tag/2.8.0
https://github.com/XKNX/xknx/releases/tag/2.9.0
Some xknx internal method signatures, used in HA, have been changed in this release. These require changes in
__init__.py
andschema.py
.Added tests for these changed validators as they were not tested previously.
Also the xknx internal address validator is now used in
config_flow.py
which allows to pass hostnames and interface names directly (but most users probably use auto-discovery anyway). The IP addresses were saved as stings before, so apart from using the validator and amendingstrings.json
there is nothing else to do 😃In 2.9.0
asyncio.wait_for
is replaces byasyncio.timeout
.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: