Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resize_keyboard and one_time_keyboard attributes to telegram bot service #91613

Merged
merged 8 commits into from May 24, 2023

Conversation

Vova-SH
Copy link
Contributor

@Vova-SH Vova-SH commented Apr 18, 2023

Proposed change

This change adds support for new optional attributes to telegram_bot services:

  • resize_keyboard
  • one_time_keyboard

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Telegram API documentation: https://docs.python-telegram-bot.org/en/v13.3/telegram.replykeyboardmarkup.html
Link to documentation pull request: home-assistant/home-assistant.io#23674
Original PR: #76320

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

Add resize_keyboard and one_time_keyboard attributes
@Vova-SH
Copy link
Contributor Author

Vova-SH commented May 17, 2023

@frenck , may you have time to look at this pull reqest?

@emontnemery emontnemery changed the title Add resize_keyboard and one_time_keyboard attributes in component "telegram bot" Add resize_keyboard and one_time_keyboard attributes to telegram bot service May 24, 2023
@home-assistant home-assistant bot marked this pull request as draft May 24, 2023 13:39
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@emontnemery emontnemery marked this pull request as ready for review May 24, 2023 13:41
@home-assistant home-assistant bot requested a review from emontnemery May 24, 2023 13:41
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Vova-SH 👍

@emontnemery emontnemery merged commit f8fdeea into home-assistant:dev May 24, 2023
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants