New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resize_keyboard and one_time_keyboard attributes to telegram bot service #91613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add resize_keyboard and one_time_keyboard attributes
home-assistant
bot
added
cla-signed
integration: telegram_bot
small-pr
PRs with less than 30 lines.
Quality Scale: No score
labels
Apr 18, 2023
PSkakalina
approved these changes
May 17, 2023
SrgGrch
approved these changes
May 17, 2023
dimafedorov9
approved these changes
May 17, 2023
TarriestZero
approved these changes
May 17, 2023
@frenck , may you have time to look at this pull reqest? |
emontnemery
changed the title
Add resize_keyboard and one_time_keyboard attributes in component "telegram bot"
Add resize_keyboard and one_time_keyboard attributes to telegram bot service
May 24, 2023
emontnemery
requested changes
May 24, 2023
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
emontnemery
reviewed
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Vova-SH 👍
emontnemery
approved these changes
May 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This change adds support for new optional attributes to
telegram_bot
services:Type of change
Additional information
Telegram API documentation: https://docs.python-telegram-bot.org/en/v13.3/telegram.replykeyboardmarkup.html
Link to documentation pull request: home-assistant/home-assistant.io#23674
Original PR: #76320
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: