New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show current day in met weather forecast #91891
Conversation
Hey there @Danielhiversen, @thimic, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
b6e8f4c
to
75550ce
Compare
Note that I wasn't able to run the all pre-commit checks due to this issue: https://community.home-assistant.io/t/receiving-pylint-error-on-commit/531494/3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Thanks already! 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Added changelog of the bumped lib to the PR description, thanks. |
Version 0.10.0 of pyMetno added the option to defined range_start when calling get_forecast: https://github.com/Danielhiversen/pyMetno/pull/35/files So let's use that to include today in the forecast.
75550ce
to
43999a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mmalina 👍
Awesome, thanks @emontnemery ! |
Version 0.10.0 of pyMetno added the option
to define range_start when calling get_forecast:
https://github.com/Danielhiversen/pyMetno/pull/35/files
So let's use that to include today in the forecast.
Full changelog of bumped dependency: Danielhiversen/pyMetno@0.9.0...0.10.0
Breaking change
This change will add current day to the weather forecast for upcoming days. If your automations/scripts
relied e.g. on the first forecasted day to be tomorrow, you will need to adjust.
Proposed change
Most weather forecasts will show the forecasted temperatures (high and low) for the current day,
so that when you check the weather in the morning, you see what you can expect on that day.
This was the odd exception. Let's fix it by including the current day.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: