Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show current day in met weather forecast #91891

Merged
merged 1 commit into from May 24, 2023

Conversation

mmalina
Copy link
Contributor

@mmalina mmalina commented Apr 23, 2023

Version 0.10.0 of pyMetno added the option
to define range_start when calling get_forecast:
https://github.com/Danielhiversen/pyMetno/pull/35/files

So let's use that to include today in the forecast.

Full changelog of bumped dependency: Danielhiversen/pyMetno@0.9.0...0.10.0

Breaking change

This change will add current day to the weather forecast for upcoming days. If your automations/scripts
relied e.g. on the first forecasted day to be tomorrow, you will need to adjust.

Proposed change

Most weather forecasts will show the forecasted temperatures (high and low) for the current day,
so that when you check the weather in the morning, you see what you can expect on that day.
This was the odd exception. Let's fix it by including the current day.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi @mmalina

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @Danielhiversen, @thimic, mind taking a look at this pull request as it has been labeled with an integration (met) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of met can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign met Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

Hi @mmalina

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@mmalina
Copy link
Contributor Author

mmalina commented Apr 23, 2023

Note that I wasn't able to run the all pre-commit checks due to this issue: https://community.home-assistant.io/t/receiving-pylint-error-on-commit/531494/3

frenck
frenck previously requested changes Apr 24, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft April 24, 2023 13:18
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mmalina mmalina marked this pull request as ready for review April 25, 2023 04:08
@home-assistant home-assistant bot requested a review from frenck April 25, 2023 04:08
@mmalina
Copy link
Contributor Author

mmalina commented Apr 25, 2023

Added changelog of the bumped lib to the PR description, thanks.

Version 0.10.0 of pyMetno added the option
to defined range_start when calling get_forecast:
https://github.com/Danielhiversen/pyMetno/pull/35/files

So let's use that to include today in the forecast.
@emontnemery emontnemery dismissed frenck’s stale review May 24, 2023 12:58

Release notes have been added

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mmalina 👍

@emontnemery emontnemery reopened this May 24, 2023
@emontnemery emontnemery merged commit d2d21b4 into home-assistant:dev May 24, 2023
61 of 70 checks passed
@mmalina
Copy link
Contributor Author

mmalina commented May 24, 2023

Awesome, thanks @emontnemery !

@mmalina mmalina deleted the met-add-current-day branch May 24, 2023 14:26
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weather missing current day's forecast
4 participants