Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality improvements and debug logs for LaCrosse View #91979

Merged
merged 5 commits into from May 25, 2023

Conversation

IceBotYT
Copy link
Contributor

@IceBotYT IceBotYT commented Apr 24, 2023

Proposed change

Trying to resolve #91743 with added debug logging to troubleshoot the issue
I also added minor code quality improvements

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

epenet
epenet previously requested changes Apr 27, 2023
tests/components/lacrosse_view/test_diagnostics.py Outdated Show resolved Hide resolved
homeassistant/components/lacrosse_view/diagnostics.py Outdated Show resolved Hide resolved
homeassistant/components/lacrosse_view/manifest.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 27, 2023 07:45
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@IceBotYT IceBotYT marked this pull request as ready for review April 28, 2023 23:41
@home-assistant home-assistant bot requested a review from epenet April 28, 2023 23:41
Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IceBotYT IceBotYT marked this pull request as draft May 2, 2023 19:43
@IceBotYT IceBotYT marked this pull request as ready for review May 2, 2023 20:18
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @IceBotYT

@emontnemery emontnemery merged commit 9231010 into home-assistant:dev May 25, 2023
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

La Crosse View - "Invalid authentication"
4 participants