Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum sensor device class in Z-Wave #92029

Merged
merged 2 commits into from Apr 29, 2023
Merged

Conversation

raman325
Copy link
Contributor

Proposed change

If I understand the ENUM device class properly, we should be using it whenever there is a finite list of possible states. This PR correctly handles those use cases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@raman325
Copy link
Contributor Author

the coverage difference is misleading because I just rewrote some code to reduce lines but those lines were already not covered

@MartinHjelmare MartinHjelmare changed the title Use enum sensor device class where appropriate Use enum sensor device class in Z-Wave Apr 26, 2023
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

What's the code coverage?

@raman325
Copy link
Contributor Author

raman325 commented Apr 28, 2023

of the 7 lines missing from patch coverage in this PR, 3 already existed but were flagged because I rewrote the code to reduce some lines. For the four I added, these are all guard statements that we shouldn't hit in a normal scenario. I do wish there was a way to validate whether these guards are actually needed but unfortunately we don't know what we don't know in terms of the devices that are out there

@raman325 raman325 merged commit 96455c7 into home-assistant:dev Apr 29, 2023
25 of 26 checks passed
@raman325 raman325 deleted the enum branch April 29, 2023 03:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants