New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pending MQTT subscribes to a single call to the paho client #92172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
core
has-tests
integration: mqtt
small-pr
PRs with less than 30 lines.
labels
Apr 28, 2023
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
jbouwh
changed the title
Merge mqtt (un)subscribes in one call to the paho client
Merge pending mqtt subscribes to a single call to the paho client
Apr 28, 2023
jbouwh
changed the title
Merge pending mqtt subscribes to a single call to the paho client
Merge pending MQTT subscribes to a single call to the paho client
Apr 28, 2023
20 tasks
jbouwh
force-pushed
the
mqtt-client-list-call
branch
from
April 28, 2023 18:28
4c036d3
to
0ca2751
Compare
19 tasks
bdraco
reviewed
Apr 29, 2023
bdraco
reviewed
Apr 29, 2023
bdraco
approved these changes
Apr 29, 2023
corporategoth
approved these changes
May 4, 2023
bdraco
approved these changes
May 8, 2023
emontnemery
approved these changes
May 8, 2023
DarkStar1973
pushed a commit
to DarkStar1973/homeassistant-core
that referenced
this pull request
May 9, 2023
…me-assistant#92172) * Merge mqtt subscribes in one call * Cleanup * cleanup, log outside of lock * Remove function wrapper * Add test that we bundle subscriptions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
code-quality
core
has-tests
integration: mqtt
Quality Scale: gold
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Merge MQTT subscribes in one call to the Paho client. This gains performance during startup. As similar tweak could be done for client unsubscribes.
See also: #92201
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: