Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lingering timer in broadlink #92179

Merged
merged 1 commit into from Apr 28, 2023

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Apr 28, 2023

Proposed change

Linked to #91360
https://github.com/home-assistant/core/actions/runs/4829217579/jobs/8604239257?pr=91360

ERROR tests/components/broadlink/test_device.py::test_device_setup_authentication_error - Failed: Lingering timer after job <Job track time interval 0:02:00 <bound method BroadlinkHeartbeat.async_heartbeat of <homeassistant.components.broadlink.heartbeat.BroadlinkHeartbeat object at 0x7f1518494df0>> HassJobType.Callback <function async_track_time_interval.<locals>.interval_listener at 0x7f150a595a20>>
ERROR tests/components/broadlink/test_device.py::test_device_setup_network_timeout - Failed: Lingering timer after job <Job track time interval 0:02:00 <bound method BroadlinkHeartbeat.async_heartbeat of <homeassistant.components.broadlink.heartbeat.BroadlinkHeartbeat object at 0x7f1508566e90>> HassJobType.Callback <function async_track_time_interval.<locals>.interval_listener at 0x7f150aa52cb0>>
ERROR tests/components/broadlink/test_device.py::test_device_setup_os_error - Failed: Lingering timer after job <Job track time interval 0:02:00 <bound method BroadlinkHeartbeat.async_heartbeat of <homeassistant.components.broadlink.heartbeat.BroadlinkHeartbeat object at 0x7f1508b5ada0>> HassJobType.Callback <function async_track_time_interval.<locals>.interval_listener at 0x7f150ab03520>>
ERROR tests/components/broadlink/test_device.py::test_device_setup_broadlink_exception - Failed: Lingering timer after job <Job track time interval 0:02:00 <bound method BroadlinkHeartbeat.async_heartbeat of <homeassistant.components.broadlink.heartbeat.BroadlinkHeartbeat object at 0x7f1518c3fdf0>> HassJobType.Callback <function async_track_time_interval.<locals>.interval_listener at 0x7f150ab01fc0>>
ERROR tests/components/broadlink/test_device.py::test_device_setup_update_network_timeout - Failed: Lingering timer after job <Job track time interval 0:02:00 <bound method BroadlinkHeartbeat.async_heartbeat of <homeassistant.components.broadlink.heartbeat.BroadlinkHeartbeat object at 0x7f15186c16c0>> HassJobType.Callback <function async_track_time_interval.<locals>.interval_listener at 0x7f1518305c60>>
ERROR tests/components/broadlink/test_device.py::test_device_setup_update_authentication_error - Failed: Lingering timer after job <Job track time interval 0:02:00 <bound method BroadlinkHeartbeat.async_heartbeat of <homeassistant.components.broadlink.heartbeat.BroadlinkHeartbeat object at 0x7f15184957b0>> HassJobType.Callback <function async_track_time_interval.<locals>.interval_listener at 0x7f150a28a680>>
ERROR tests/components/broadlink/test_device.py::test_device_setup_update_broadlink_exception - Failed: Lingering timer after job <Job track time interval 0:02:00 <bound method BroadlinkHeartbeat.async_heartbeat of <homeassistant.components.broadlink.heartbeat.BroadlinkHeartbeat object at 0x7f150a5803a0>> HassJobType.Callback <function async_track_time_interval.<locals>.interval_listener at 0x7f1509d4ee60>>
ERROR tests/components/broadlink/test_device.py::test_device_unload_authentication_error - Failed: Lingering timer after job <Job track time interval 0:02:00 <bound method BroadlinkHeartbeat.async_heartbeat of <homeassistant.components.broadlink.heartbeat.BroadlinkHeartbeat object at 0x7f1508a72e60>> HassJobType.Callback <function async_track_time_interval.<locals>.interval_listener at 0x7f150a18a7a0>>
ERROR tests/components/broadlink/test_device.py::test_device_unload_update_failed - Failed: Lingering timer after job <Job track time interval 0:02:00 <bound method BroadlinkHeartbeat.async_heartbeat of <homeassistant.components.broadlink.heartbeat.BroadlinkHeartbeat object at 0x7f150bec73d0>> HassJobType.Callback <function async_track_time_interval.<locals>.interval_listener at 0x7f150a056dd0>>

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Danielhiversen, @felipediel, @L-I-Am, mind taking a look at this pull request as it has been labeled with an integration (broadlink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of broadlink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign broadlink Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck merged commit 397a5ff into home-assistant:dev Apr 28, 2023
24 checks passed
@epenet epenet deleted the broadlink-lingering-timer branch April 28, 2023 19:11
@epenet epenet mentioned this pull request Apr 28, 2023
89 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants