-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement strict-typing for Plugwise #92253
Conversation
Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
1dad80f
to
ee3912e
Compare
Very nice job @CoMPaTech getting rid of the remaining Any-related mypy-warnings! |
@epenet if you have time please review as well, thanks! |
There is no need to rebase if there are no conflicts. Also, is it possible to first create a PR with just the library bump (with only associated needed changes), and then set strict typing in a follow-up PR? |
Good call, diverting version bump to #93088 - @bouwew can you 'draft' this one until that PR is completed (as we will need to rebase this one from that) |
Closing, outdated. |
Proposed change
Implement Implement strict-typing for Plugwise - via plugwise v0.31.3
And adapt the Plugwise code where needed.
https://github.com/plugwise/python-plugwise/releases/tag/v0.31.2
https://github.com/plugwise/python-plugwise/releases/tag/v0.31.3
plugwise/python-plugwise@v0.31.1...v0.31.3
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: