Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement strict-typing for Plugwise #92253

Closed
wants to merge 12 commits into from

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Apr 29, 2023

Proposed change

Implement Implement strict-typing for Plugwise - via plugwise v0.31.3
And adapt the Plugwise code where needed.

https://github.com/plugwise/python-plugwise/releases/tag/v0.31.2
https://github.com/plugwise/python-plugwise/releases/tag/v0.31.3
plugwise/python-plugwise@v0.31.1...v0.31.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of plugwise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign plugwise Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@CoMPaTech CoMPaTech force-pushed the plugwise_typed branch 3 times, most recently from 1dad80f to ee3912e Compare May 5, 2023 12:13
@bouwew
Copy link
Contributor Author

bouwew commented May 5, 2023

Very nice job @CoMPaTech getting rid of the remaining Any-related mypy-warnings!

@bouwew bouwew marked this pull request as ready for review May 5, 2023 17:52
@bouwew bouwew requested a review from frenck as a code owner May 5, 2023 17:53
@bouwew
Copy link
Contributor Author

bouwew commented May 5, 2023

@epenet if you have time please review as well, thanks!

@CoMPaTech
Copy link
Contributor

@epenet @frenck Should we keep rebasing this PR pending review or can we just leave it as is until reviewed?

@epenet
Copy link
Contributor

epenet commented May 15, 2023

There is no need to rebase if there are no conflicts.
Looking quickly at this PR, it looks like the library is missing a release/tag for v0.31.3 (only v0.31.2 is visible in the releases)

Also, is it possible to first create a PR with just the library bump (with only associated needed changes), and then set strict typing in a follow-up PR?

@CoMPaTech
Copy link
Contributor

There is no need to rebase if there are no conflicts. Looking quickly at this PR, it looks like the library is missing a release/tag for v0.31.3 (only v0.31.2 is visible in the releases)

Also, is it possible to first create a PR with just the library bump (with only associated needed changes), and then set strict typing in a follow-up PR?

Good call, diverting version bump to #93088 - @bouwew can you 'draft' this one until that PR is completed (as we will need to rebase this one from that)

@bouwew bouwew marked this pull request as draft May 15, 2023 15:56
@bouwew
Copy link
Contributor Author

bouwew commented Aug 10, 2023

Closing, outdated.

@bouwew bouwew closed this Aug 10, 2023
@bouwew bouwew deleted the plugwise_typed branch August 10, 2023 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants