New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matter cover position improvements #92278
Matter cover position improvements #92278
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This PR should wait for the first PR to be merged to be rebased over that merge |
ba45f60
to
ed97e32
Compare
7c67ce2
to
0e6e195
Compare
91ba9dd
to
33581da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Thank you guys! So glad I could contribute to Home Assistant 😊! |
No, thank you for your contribution, that is really appreciated! |
This would be the comparation between first and second pr: diffProposed change
CurrentPositionLiftPercentage
andCurrentPositionTiltPercentage
toCurrentPositionLiftPercent100ths
andCurrentPositionTiltPercent100ths
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: