Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code from nest yaml migration and OOB auth deprecation #92311

Merged
merged 1 commit into from May 1, 2023

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Apr 30, 2023

Breaking change

Nest yaml configuration has been fully removed. You should ensure you have imported your configuration and credentials into the UI before upgrading. Nest Desktop or OOB authentication, which was previously disabled by Google, has now been removed.

Proposed change

Cleanup code from previous migrations removing support for nest configuration in yaml migration and for migration to new application credentials type due to OOB auth deprecation.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter allenporter marked this pull request as ready for review April 30, 2023 21:11
@bdraco
Copy link
Member

bdraco commented Apr 30, 2023

Should we mark this as a breaking change or is there no point?

@allenporter
Copy link
Contributor Author

Should we mark this as a breaking change or is there no point?

Good point, I've gone ahead and included the breaking change in the PR description.

@allenporter allenporter merged commit e7433c4 into home-assistant:dev May 1, 2023
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants