Fortios device tracker updates #92331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for FortiOS 7.0 and retaining FortiOS 6.4 support. Since an API was deprecated in FortiOS 7.0 and replace by a new API the integration now also support FortiOS 7.0. It is planned to deprecate the support for FortiOS 6.4 in a year
indentation fix
run flake8 fixes
black fixing line breaks
black fixes
linter fixes
linter fixes
linter fix
removed comment that pylint does not like :-~
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
to resolve double guard for supported versions.
Deprecated old api. cleaned up code. better checking with try-catch removed unnecessary error output.
lint compliance.
lint updates
lint updates
lint updates
lint updates
updated to use awesomeversion component.
pylint updates
pylint updates
bug fix. Check on json keys before accessing them. performance optimise, by filtering on the parameters to fetch from FortiGate.
performance optimisation, bug fix and update to work with HASS 2023.4
removed as requested.
MartinHjelmare
requested changes
Jun 12, 2023
reverted all refactoring and only fixed the open issue.
added newline at EOF
removed unused import.
mypy fixes
added typing
|
Thanks for the good improvements. all resolved. |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
MartinHjelmare
requested changes
Jun 15, 2023
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Updated Fortios device tracker with bugfixes which caused the device tracker to no respond any values due to a change in the API format returned by FortiOS.
Performance uptimization.
Thanks to @julian0703 for helping with finding the bug, suggestions and testing.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: