New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a custom panel for KNX with a group monitor #92355
Conversation
Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This is really cool and i'd love to see this in. Is panel_custom is the right way to go? Seems to be very little use of that inside HA. Panels tend to be added directly to the frontend repo. |
That was Paulus' suggestion. Afaik it's only used for Insteon currently, and there is an open PR for Dynalite doing the same. I guess only selected / wider used integrations get to go directly into the frontend repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good. Would be good with some other eyes on it too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good. Tested again locally and working flawlessly. Since I was involved in the coding I'd rather not merge this on my own. This should be reviewed by ha/core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. A second opinion from somebody with more knowledge of custom_panel would be good.
I built the Insteon side panel and this LGTM. |
I'm gonna merge this since we have three approving reviews on this. Thank you all! |
Proposed change
This adds a custom panel for the KNX integration which allows to upload a project file (
.knxproj
) and offers a group monitor for live bus diagnostics.More features shall follow later - this was our idea of a MVP for a custom KNX panel.
New requirements
xknxproject - the project data parser https://github.com/XKNX/xknxproject/
knx-frontend - the package containing the panels frontend code https://github.com/XKNX/knx-frontend/
Screenshots
Project information and uploader
Group monitor
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: