Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont reload integration on auth error in Aladdin Connect #92399

Merged
merged 1 commit into from May 5, 2023

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented May 3, 2023

Proposed change

The site report 401 errors when attempting to re-authenticate during site maintenance (some times daily) - not reloading the integration will allow it to keep trying. If the user reloads/restarts the reauth_flow will still be triggered.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@mkmer mkmer changed the title Aladdin Conect: Dont reload integration on auth error Dont reload integration on auth error in Aladdin Connect May 3, 2023
@gjohansson-ST
Copy link
Member

There isn't a better way to handle this (see that it's in maintenance or something else)?

@mkmer
Copy link
Contributor Author

mkmer commented May 5, 2023

It appears to be a problem with the authentication server side of things - it can't authenticate somewhere on the backend and front end website returns a 401 (It tries twice - once in the poll step, then if it fails it reloads and tries again and both fail). I haven't found another way to test for password validity besides the 401. It would be nice if the site would tell us with a 410 or anything other than 401 or 403 when it's parts a missing)
I'll keep looking, but for now this is the least offensive way for users... besides the site doesn't force password changes so it never really changes anyway :)
I am totally open to other suggestions.

Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good change.

@elupus elupus merged commit 774f1c8 into home-assistant:dev May 5, 2023
24 checks passed
@mkmer mkmer deleted the Aladdin_connect-dont-reload branch May 6, 2023 12:53
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants