Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move naming of entities in Rituals Perfume Genie #92482

Merged
merged 1 commit into from May 4, 2023
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented May 4, 2023

Proposed change

This is a small pre-refactor step towards more refactoring to come.

Currently, the names of entities are defined in the base entity. This moves it to each individual entity class (out of the base entity).

This enables the ability to refactor each platform to entity descriptions in individual follow-up PRs (this is a step in keeping follow-ups smaller).

PS: Yes, entity names and such should be possible by now, and so are translations, will do that in follow-up PRs (just like entity descriptions).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 4, 2023

Hey there @milanmeu, mind taking a look at this pull request as it has been labeled with an integration (rituals_perfume_genie) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rituals_perfume_genie can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rituals_perfume_genie Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck added smash Indicator this PR is close to finish for merging or closing and removed by-code-owner Quality Scale: silver labels May 4, 2023
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@frenck frenck merged commit 46bf0e5 into dev May 4, 2023
24 checks passed
@frenck frenck deleted the frenck-2023-0763 branch May 4, 2023 10:25
dknowles2 pushed a commit to dknowles2/ha-core that referenced this pull request May 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality integration: rituals_perfume_genie small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants