Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lingering timer in duckdns #92516

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix lingering timer in duckdns #92516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 12 additions & 3 deletions homeassistant/components/duckdns/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@
import voluptuous as vol

from homeassistant.const import CONF_ACCESS_TOKEN, CONF_DOMAIN
from homeassistant.core import CALLBACK_TYPE, HomeAssistant, ServiceCall, callback
from homeassistant.core import (
CALLBACK_TYPE,
HassJob,
HomeAssistant,
ServiceCall,
callback,
)
from homeassistant.helpers.aiohttp_client import async_get_clientsession
import homeassistant.helpers.config_validation as cv
from homeassistant.helpers.event import async_call_later
Expand Down Expand Up @@ -110,7 +116,7 @@ def async_track_time_interval_backoff(
"""Add a listener that fires repetitively at every timedelta interval."""
if not isinstance(intervals, (list, tuple)):
intervals = (intervals,)
remove = None
remove: CALLBACK_TYPE | None = None
failed = 0

async def interval_listener(now: datetime) -> None:
Expand All @@ -122,8 +128,11 @@ async def interval_listener(now: datetime) -> None:
failed = 0
finally:
delay = intervals[failed] if failed < len(intervals) else intervals[-1]
remove = async_call_later(hass, delay.total_seconds(), interval_listener)
remove = async_call_later(
hass, delay.total_seconds(), interval_listener_job
)

interval_listener_job = HassJob(interval_listener, cancel_on_shutdown=True)
hass.async_run_job(interval_listener, dt_util.utcnow())

def remove_listener() -> None:
Expand Down