Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception handling in Microsoft TTS #92556

Merged
merged 1 commit into from May 25, 2023
Merged

Fix exception handling in Microsoft TTS #92556

merged 1 commit into from May 25, 2023

Conversation

daradib
Copy link
Contributor

@daradib daradib commented May 4, 2023

Proposed change

pycsspeechtts uses the requests library, but Microsoft TTS previously caught HTTPException from the standard library. This is changed to catch requests.HTTPError and return (None, None) consistent with other TTS integrations. This will properly raise HomeAssistantError for display in the frontend.

Merge after PR #92215 which adds tests for Microsoft TTS.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@iMicknl iMicknl marked this pull request as ready for review May 6, 2023 20:07
@iMicknl iMicknl marked this pull request as draft May 6, 2023 20:07
@daradib daradib mentioned this pull request May 16, 2023
Merged
20 tasks
@daradib daradib marked this pull request as ready for review May 24, 2023 21:37
@daradib
Fix exception handling in Microsoft TTS
47a2578 
pycsspeechtts uses the requests library, but Microsoft TTS previously
caught HTTPException from the standard library. This is changed to
catch requests.HTTPError and return `(None, None)` consistent with
other TTS integrations. This will properly raise HomeAssistantError
for display in the frontend.

Follow up to PR home-assistant#92215 which adds tests for Microsoft TTS.
emontnemery
emontnemery approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @daradib 👍

@emontnemery emontnemery merged commit e2daffc into home-assistant:dev May 25, 2023
20 checks passed
hookedonunix pushed a commit to hookedonunix/home-assistant that referenced this pull request May 26, 2023
@daradib @hookedonunix
Fix exception handling in Microsoft TTS (home-assistant#92556)
1760932 
pycsspeechtts uses the requests library, but Microsoft TTS previously
caught HTTPException from the standard library. This is changed to
catch requests.HTTPError and return `(None, None)` consistent with
other TTS integrations. This will properly raise HomeAssistantError
for display in the frontend.

Follow up to PR home-assistant#92215 which adds tests for Microsoft TTS.
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emontnemery emontnemery emontnemery approved these changes

Assignees
No one assigned
Labels
bugfix cla-signed has-tests integration: microsoft Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daradib @emontnemery