Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-run expose entities migration if first time failed #92564

Merged
merged 3 commits into from May 5, 2023
Merged

Re-run expose entities migration if first time failed #92564

merged 3 commits into from May 5, 2023

Conversation

balloob
Copy link
Member

@balloob balloob commented May 5, 2023

Breaking change

Proposed change

This runs the expose entities migration again if the first time failed, due to a bug in 2023.5.0 (fixed in .1).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 5, 2023

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@balloob balloob added this to the 2023.5.2 milestone May 5, 2023
balloob
balloob commented May 5, 2023
View reviewed changes
homeassistant/components/cloud/alexa_config.py Outdated
if self._prefs.alexa_settings_version < 2 or (
# Recover from a bug we had in 2023.5.0 where entities didn't get exposed
self._prefs.alexa_settings_version < 3
and len(async_get_assistant_settings(hass, CLOUD_ALEXA)) == 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should count number of exposed entities instead

@balloob balloob marked this pull request as ready for review May 5, 2023 11:13
@balloob balloob merged commit 19dcc8c into dev May 5, 2023
52 checks passed
@balloob balloob deleted the rerun-expose-entities-migration branch May 5, 2023 12:11
balloob added a commit that referenced this pull request May 5, 2023
@balloob @emontnemery
Re-run expose entities migration if first time failed (#92564)
e8808b5 
* Re-run expose entities migration if first time failed

* Count number of exposed entities

* Add tests

---------

Co-authored-by: Erik <erik@montnemery.com>
@balloob balloob mentioned this pull request May 5, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-picked cla-signed core has-tests integration: cloud Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.5.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balloob @emontnemery