Add ability to shutdown a coordinator on STOP #92611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
bdraco
reviewed
May 5, 2023
| @@ -117,6 +119,22 @@ def __init__( | |||
| if self.config_entry: | |||
| self.config_entry.async_on_unload(self.async_shutdown) | |||
|
|
|||
| async def async_register_shutdown(self) -> None: | |||
There was a problem hiding this comment.
Any reason to not allow this to be canceled?
There was a problem hiding this comment.
I'm not sure that's necessary.
In what context might you want to cancel a shutdown registration?
There was a problem hiding this comment.
What if the integration gets reloaded but its not a config entry?
There was a problem hiding this comment.
In that case, you still have to manually shut it down, which takes care of cancelling the event registration.
See sample implementation use in https://github.com/home-assistant/core/pull/92578/files
bdraco
approved these changes
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Linked to #92578
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: