Update quality scale of devolo Home Control #92646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
If I'm not mistaken, the devolo Home Control integration reached the gold quality scale.
✔ Don't allow configuring already configured device/service
✔ Discoverable
✔ Set unique ID in config flow
✔ Raise ConfigEntryNotReady if unable to connect during entry setup
✔ Entities have device info
✔ Full test coverage for the config flow
✔ Above average test coverage for all integration modules
✔ Tests for fetching data from the integration and controlling it
✔ Has a code owner
✔ Entities only subscribe to updates inside async_added_to_hass and unsubscribe inside async_will_remove_from_hass
✔ Entities have correct device classes where appropriate
✔ Supports entities being disabled and leverages Entity.entity_registry_enabled_default to disable less popular entities
✔ If the device/service API can remove entities, the integration should make sure to clean up the entity and device registry.
✔ When communicating with a device or service, the integration implements the diagnostics platform which redacts sensitive information.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: