Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quality scale of devolo Home Control #92646

Merged
merged 1 commit into from May 24, 2023

Conversation

Shutgun
Copy link
Contributor

@Shutgun Shutgun commented May 5, 2023

Proposed change

If I'm not mistaken, the devolo Home Control integration reached the gold quality scale.

✔ Don't allow configuring already configured device/service
✔ Discoverable
✔ Set unique ID in config flow
✔ Raise ConfigEntryNotReady if unable to connect during entry setup
✔ Entities have device info
✔ Full test coverage for the config flow
✔ Above average test coverage for all integration modules
✔ Tests for fetching data from the integration and controlling it
✔ Has a code owner
✔ Entities only subscribe to updates inside async_added_to_hass and unsubscribe inside async_will_remove_from_hass
✔ Entities have correct device classes where appropriate
✔ Supports entities being disabled and leverages Entity.entity_registry_enabled_default to disable less popular entities
✔ If the device/service API can remove entities, the integration should make sure to clean up the entity and device registry.
✔ When communicating with a device or service, the integration implements the diagnostics platform which redacts sensitive information.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 5, 2023

Hey there @2Fake, mind taking a look at this pull request as it has been labeled with an integration (devolo_home_control) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of devolo_home_control can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign devolo_home_control Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@emontnemery emontnemery merged commit 9363fa6 into home-assistant:dev May 24, 2023
24 checks passed
@Shutgun Shutgun deleted the hc_quality_scale branch May 24, 2023 08:22
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants