Move yaml configuration to integration key for command_line

[gjohansson-ST]

Breaking change

Proposed change

Move yaml configuration to integration key for command_line

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Move Command Line to integration key home-assistant.io#27343

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[emontnemery]

I think this looks great @gjohansson-ST 👍

One comment though, I'm not sure the configuration format you propose here is preferred over a simple list as used by for example the template integration:

  - sensor:
      ... a sensor
  - binary_sensor:
      ... a binary sensor
  - sensor:
      ...  another sensor

[emontnemery]

Let's not keep using "devices" here, either call the dict "entities" or "covers"

[emontnemery]

Nice!

[emontnemery]

@frenck @MartinHjelmare Could we document a best practice for entity configuration in https://github.com/home-assistant/architecture/blob/master/adr/0007-integration-config-yaml-structure.md ?

[gjohansson-ST]

One comment though, I'm not sure the configuration format you propose here is preferred over a simple list as used by for example the template integration:

  - sensor:
      ... a sensor
  - binary_sensor:
      ... a binary sensor
  - sensor:
      ...  another sensor

I wasn't sure but for cover and switch there was also this object_id used as fallback for name and entity_id (I think) therefore using this config format.
Personally I prefer the format you suggest which is also what has been done in many other places but it would remove certain functionality on this particular "migration".
Perhaps that's ok as we should have unique_id anyway so one can change the name etc. etc. anyhow?

[emontnemery]

I opened an architecture issue to discuss documenting a preferred YAML format for entities: home-assistant/architecture#906

[emontnemery]

for cover and switch there was also this object_id used as fallback for name and entity_id

Yes, but we don't need to be 100% compatible with the old format. It's also confusing because most of the platforms ignore the dictionary key, it's not used for either name fallback or as input for entity_id as I understand it?

[gjohansson-ST]

for cover and switch there was also this object_id used as fallback for name and entity_id

Yes, but we don't need to be 100% compatible with the old format. It's also confusing because most of the platforms ignore the dictionary key, it's not used for either name fallback or as input for entity_id as I understand it?

Agree, I think maybe it came before unique_id was added and used so it doesn't make sense anymore. Will change.

[emontnemery]

I'm setting this PR to draft, please mark it as ready for review when you've updated the schema @gjohansson-ST 👍

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.