New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete persistent notifications migration #92828
Conversation
Persistent notifications are no longer stored in the state machine and no longer fire events
Persistent notifications are no longer stored in the state machine and no longer fire events
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
We should mark the removal from the state machine as a breaking change. Some people have used it in the past to automatically dismiss certain notifications. |
Adjusted the text. |
* Complete migration of persistent notifications Persistent notifications are no longer stored in the state machine and no longer fire events * Complete migration of persistent notifications Persistent notifications are no longer stored in the state machine and no longer fire events * fixes * fixes * fixes * ws test * update tests * update tests * fix more tests * fix more tests * more fixes * fix * fix person * fix person * keep whitelist * use singleton
* Complete migration of persistent notifications Persistent notifications are no longer stored in the state machine and no longer fire events * Complete migration of persistent notifications Persistent notifications are no longer stored in the state machine and no longer fire events * fixes * fixes * fixes * ws test * update tests * update tests * fix more tests * fix more tests * more fixes * fix * fix person * fix person * keep whitelist * use singleton
frontend: home-assistant/frontend#16476
Breaking change
Persistent notifications are no longer stored in the state machine.
The
notification_id
is no longer mutated withslugify
. When calling thedismiss
service, always pass the originalnotification_id
that was passed in.Proposed change
The migration (started in #57157) to using a websocket subscription for persistent notifications is complete.
This solves the following problems:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests:
TODO:
configurator
-- is this needed?looks like it still works