New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airzone select improvements #92894
Airzone select improvements #92894
Conversation
8bc081e
to
73a0bd7
Compare
Fixes late comment when select platform was introduced. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This was a late comment when the select platform was introduced. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
c684941
to
8b6d914
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
5f1b8bf
to
f3d50f9
Compare
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
f3d50f9
to
93f8bd1
Compare
This was requested in order to keep control of the translation strings. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
"90deg": "90º", | ||
"50deg": "50º", | ||
"45deg": "45º", | ||
"40deg": "40º" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use the degree symbol here
"90deg": "90º", | |
"50deg": "50º", | |
"45deg": "45º", | |
"40deg": "40º" | |
"90deg": "90°", | |
"50deg": "50°", | |
"45deg": "45°", | |
"40deg": "40°" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 4087cde
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Noltari 👍
The requested changes have been implemented
Thanks! |
Proposed change
This fixes two late comments from the PR which introduced Select platform support for Airzone:
From @bdraco Add Airzone Select platform support #76415 (comment)
Make select options translatable.
From @MartinHjelmare Add Airzone Select platform support #76415 (comment)
Remove unneeded
.keys()
when copying dict to list.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: