Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airzone select improvements #92894

Merged
merged 12 commits into from May 24, 2023

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented May 10, 2023

Proposed change

This fixes two late comments from the PR which introduced Select platform support for Airzone:

  1. From @bdraco Add Airzone Select platform support #76415 (comment)
    Make select options translatable.

  2. From @MartinHjelmare Add Airzone Select platform support #76415 (comment)
    Remove unneeded .keys() when copying dict to list.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Fixes late comment when select platform was introduced.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This was a late comment when the select platform was introduced.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari force-pushed the airzone-select-improvements branch from c684941 to 8b6d914 Compare May 10, 2023 15:43
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 10, 2023 17:13
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari force-pushed the airzone-select-improvements branch 3 times, most recently from 5f1b8bf to f3d50f9 Compare May 11, 2023 10:30
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari force-pushed the airzone-select-improvements branch from f3d50f9 to 93f8bd1 Compare May 11, 2023 10:31
@Noltari Noltari marked this pull request as ready for review May 11, 2023 10:36
@gjohansson-ST gjohansson-ST added the smash Indicator this PR is close to finish for merging or closing label May 14, 2023
@home-assistant home-assistant bot marked this pull request as draft May 15, 2023 09:48
This was requested in order to keep control of the translation strings.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari marked this pull request as ready for review May 15, 2023 14:01
homeassistant/components/airzone/select.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 15, 2023 17:12
@Noltari Noltari marked this pull request as ready for review May 15, 2023 19:24
Comment on lines 31 to 34
"90deg": "90º",
"50deg": "50º",
"45deg": "45º",
"40deg": "40º"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the degree symbol here

Suggested change
"90deg": "90º",
"50deg": "50º",
"45deg": "45º",
"40deg": "40º"
"90deg": "90°",
"50deg": "50°",
"45deg": "45°",
"40deg": "40°"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4087cde

@home-assistant home-assistant bot marked this pull request as draft May 23, 2023 17:14
@Noltari Noltari marked this pull request as ready for review May 23, 2023 19:10
@home-assistant home-assistant bot requested a review from emontnemery May 23, 2023 19:10
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Noltari 👍

@emontnemery emontnemery dismissed MartinHjelmare’s stale review May 24, 2023 06:21

The requested changes have been implemented

@emontnemery emontnemery merged commit a29adc0 into home-assistant:dev May 24, 2023
24 checks passed
@Noltari
Copy link
Contributor Author

Noltari commented May 24, 2023

Thanks, @Noltari 👍

Thanks!

@Noltari Noltari deleted the airzone-select-improvements branch May 24, 2023 06:23
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed code-quality has-tests integration: airzone Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants