Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for group into command_line auth provider #92906

Merged
merged 3 commits into from Nov 24, 2023
Merged

Support for group into command_line auth provider #92906

merged 3 commits into from Nov 24, 2023

Conversation

Hejki
Copy link
Contributor

@Hejki Hejki commented May 10, 2023 •
edited

Proposed change

Extend meta keywords for command_line auth provider.

  • variable group can contain group id to create new user with specific group
  • variable local_only for define local only user (true or false)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-needed core new-feature small-pr PRs with less than 30 lines. labels May 10, 2023
@home-assistant
Copy link

Hi @Hejki

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Hejki Hejki mentioned this pull request May 10, 2023
Merged
8 tasks
@Hejki Hejki marked this pull request as ready for review May 10, 2023 19:27
@Hejki Hejki force-pushed the feature/command_line_meta branch from 1fa04a2 to 8936d4a Compare May 10, 2023 19:28
@Hejki Hejki force-pushed the feature/command_line_meta branch 3 times, most recently from c47bf47 to 0f4e0d2 Compare May 30, 2023 10:34
@Hejki Hejki force-pushed the feature/command_line_meta branch 2 times, most recently from 0651ce4 to 7ba2adb Compare June 14, 2023 08:40
@Hejki Hejki force-pushed the feature/command_line_meta branch from 7ba2adb to fbe383e Compare June 20, 2023 07:22
@Hejki Hejki force-pushed the feature/command_line_meta branch from fbe383e to ab6b5cb Compare June 28, 2023 11:07
@Hejki Hejki force-pushed the feature/command_line_meta branch 2 times, most recently from 7e2a3ee to c2f9a28 Compare July 26, 2023 07:46
@Hejki Hejki force-pushed the feature/command_line_meta branch 2 times, most recently from 205bb07 to 2069769 Compare August 3, 2023 07:02
@Hejki
Support for group into command_line auth provider
306485e 
Extend meta keywords for command_line auth provider.
* meta `group` can contain group id to create new user with specific group
* meta `local_only` for define local only user (true or false)
emontnemery
emontnemery approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me and seem to make sense. However, I'd like a second opinion from someone more familiar with the auth code before merging.

@emontnemery emontnemery added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Nov 24, 2023
MartinHjelmare
MartinHjelmare approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this looks fine. Thanks!

@MartinHjelmare MartinHjelmare removed the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Nov 24, 2023
@frenck
Copy link
Member

frenck commented Nov 24, 2023

The CI failure is unrelated. I'll go ahead an ignore this CI failure.

../Frenck

@frenck frenck merged commit 65a2f5b into home-assistant:dev Nov 24, 2023
48 of 49 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@emontnemery emontnemery emontnemery approved these changes

Assignees
No one assigned
Labels
cla-signed core new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hejki @frenck @MartinHjelmare @emontnemery