New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Netgear LTE constants to their own file #92924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a mix of multiple refactoring.
Moving constants should be one PR, moving base entity another, using _attr_has_entity_name and attributes should be again a follow-up.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
||
SCAN_INTERVAL = timedelta(seconds=10) | ||
DISPATCHER_NETGEAR_LTE = "netgear_lte_update" | ||
|
||
CONF_NOTIFY: Final = "notify" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three can be dropped. They are now in const.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant the platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Breaking change
Proposed change
Preliminary PR as suggested by @epenet before #92632 is to be merged
Move constants to their own file
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: