New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change utility_meter log level for invalid old state #93026
Change utility_meter log level for invalid old state #93026
Conversation
Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I think yes, because all that checks in PRs are related to |
People seam to care more about the warning message then the root cause of the warning message, so yes... I'm tempted to accept this PR |
I can agree with you, the point is that a warning should indicate a potential issue, and in this case this is not a real issue. Not everybody have the capacity to analyze the code, so if they receive a warning just warn 🤔. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this to decrease log spam. If debug is too low, we can adjust the severity again 👍
Proposed change
The warning log that warn about an invalid
old
state in the utility meter seems excessive and is normally logged when HA is started and state from the source sensor is still unavailable or unknown. I propose to lower this log to debug level. Warning log about invalidnew
state is available few row above.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: