Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change utility_meter log level for invalid old state #93026

Merged
merged 1 commit into from May 24, 2023

Conversation

ollo69
Copy link
Contributor

@ollo69 ollo69 commented May 13, 2023

Proposed change

The warning log that warn about an invalid old state in the utility meter seems excessive and is normally logged when HA is started and state from the source sensor is still unavailable or unknown. I propose to lower this log to debug level. Warning log about invalid new state is available few row above.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (utility_meter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of utility_meter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign utility_meter Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@epenet
Copy link
Contributor

epenet commented May 15, 2023

Is this still needed after merge of #91035 and/or #92825?

@ollo69
Copy link
Contributor Author

ollo69 commented May 15, 2023

I think yes, because all that checks in PRs are related to current state but the warning is related to old state. So when current state is valid it tries to calculate the difference, but because the old state is something like UNKNOWN or UNAVAILABLE generate the warning.

@dgomes
Copy link
Contributor

dgomes commented May 15, 2023

People seam to care more about the warning message then the root cause of the warning message, so yes... I'm tempted to accept this PR

@ollo69
Copy link
Contributor Author

ollo69 commented May 15, 2023

@dgomes,

I can agree with you, the point is that a warning should indicate a potential issue, and in this case this is not a real issue. Not everybody have the capacity to analyze the code, so if they receive a warning just warn 🤔.
As alternative solution we could add additional check for specific situation, but probably in this case is more simple to just reduce the log level.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this to decrease log spam. If debug is too low, we can adjust the severity again 👍

@emontnemery emontnemery merged commit 62ccecb into home-assistant:dev May 24, 2023
24 checks passed
@ollo69 ollo69 deleted the utilitymeter-change-loglevel branch May 24, 2023 07:18
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants