Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lingering timer in withings #93085

Merged
merged 2 commits into from May 15, 2023
Merged

Fix lingering timer in withings #93085

merged 2 commits into from May 15, 2023

Conversation

epenet
Copy link
Contributor

@epenet epenet commented May 15, 2023

Proposed change

Linked to #91360
https://github.com/home-assistant/core/actions/runs/4923668065/jobs/8795823449?pr=91360

ERROR tests/components/withings/test_binary_sensor.py::test_binary_sensor - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c6db8720>>
ERROR tests/components/withings/test_common.py::test_webhook_post[0-0-1-0] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c596cae0>>
ERROR tests/components/withings/test_init.py::test_auth_failure[exception0] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fe36583f600>>
ERROR tests/components/withings/test_common.py::test_webhook_post[0-None-1-0] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c5f39580>>
ERROR tests/components/withings/test_init.py::test_auth_failure[exception1] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fe3670380e0>>
ERROR tests/components/withings/test_common.py::test_webhook_post[0-None-None-12] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c651c860>>
ERROR tests/components/withings/test_init.py::test_auth_failure[exception2] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fe367450220>>
ERROR tests/components/withings/test_common.py::test_webhook_post[0-GG-None-20] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c5f7a8e0>>
ERROR tests/components/withings/test_init.py::test_set_config_unique_id - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fe3676542c0>>
ERROR tests/components/withings/test_common.py::test_webhook_post[0-0-None-20] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c5a9af20>>
ERROR tests/components/withings/test_common.py::test_webhook_post[0-0-99-21] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c5762660>>
ERROR tests/components/withings/test_common.py::test_webhook_post[0-11-1-0] - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c569fd80>>
ERROR tests/components/withings/test_common.py::test_webhook_head - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c56342c0>>
ERROR tests/components/withings/test_common.py::test_webhook_put - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fc6c54c5080>>
ERROR tests/components/withings/test_sensor.py::test_sensor_default_enabled_entities - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fe367244a40>>
ERROR tests/components/withings/test_sensor.py::test_all_entities - Failed: Lingering timer after job <Job call_later 1 HassJobType.Callback <function async_setup_entry.<locals>.async_call_later_callback at 0x7fe3676ddd00>>

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @vangorra, mind taking a look at this pull request as it has been labeled with an integration (withings) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of withings can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign withings Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@epenet epenet marked this pull request as ready for review May 15, 2023 07:51
data={"token": {"userid": "my_user_id"}, "profile": person0.profile},
data={
"token": {"userid": "my_user_id"},
"auth_implementation": "withings",
Copy link
Contributor Author

@epenet epenet May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing auth_implementation here caused the config entry unload to fail for this specific test.

@epenet epenet mentioned this pull request May 15, 2023
89 tasks
@frenck frenck merged commit b38a7aa into home-assistant:dev May 15, 2023
24 checks passed
@epenet epenet deleted the withings branch May 15, 2023 20:02
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants