Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable cleanup_closed on cpython >= 3.11.4 #93120

Merged
merged 1 commit into from May 15, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 15, 2023

Proposed change

The problem that caused us to turn this off
has been fixed upstream in 3.11.4

python/cpython#104485

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

The problem that caused us to turn this off
has been fixed upstream in 3.11.4

python/cpython#104485
@bdraco bdraco requested a review from a team as a code owner May 15, 2023 18:12
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels May 15, 2023
@frenck frenck merged commit 72a6d3a into dev May 15, 2023
51 of 52 checks passed
@frenck frenck deleted the cleanup_closed_fixed_3114 branch May 15, 2023 19:29
@bdraco
Copy link
Member Author

bdraco commented May 15, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants