New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up signing paths #93127
Speed up signing paths #93127
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
now_timestamp = int(now.timestamp()) | ||
expiration_timestamp = now_timestamp + int(expiration.total_seconds()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JWT wants timestamps as int. Doing this here instead and passing to api_jws avoids all the expensive conversions and copies since our times are always in UTC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bdraco 👍
../Frenck
Proposed change
Speed up signing paths. This is small QOL improvement when watching cameras.
I noticed we could speed this up a bit when testing the new PyJWT (#93128)
We could get a bit more out of this since api_jws is using built-in JSON but I didn't want to re-implement that function because it seems like risk we didn't want to carry. https://github.com/jpadilla/pyjwt/blob/d7c54dbebdab2ae17f7948fd4432b15e1bb82852/jwt/api_jws.py#L103
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: