Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up signing paths #93127

Merged
merged 4 commits into from May 17, 2023
Merged

Speed up signing paths #93127

merged 4 commits into from May 17, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 15, 2023

Proposed change

Speed up signing paths. This is small QOL improvement when watching cameras.

I noticed we could speed this up a bit when testing the new PyJWT (#93128)

We could get a bit more out of this since api_jws is using built-in JSON but I didn't want to re-implement that function because it seems like risk we didn't want to carry. https://github.com/jpadilla/pyjwt/blob/d7c54dbebdab2ae17f7948fd4432b15e1bb82852/jwt/api_jws.py#L103

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco requested a review from a team as a code owner May 15, 2023 20:43
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (http) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of http can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign http Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Comment on lines 66 to 67
now_timestamp = int(now.timestamp())
expiration_timestamp = now_timestamp + int(expiration.total_seconds())
Copy link
Member Author

@bdraco bdraco May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JWT wants timestamps as int. Doing this here instead and passing to api_jws avoids all the expensive conversions and copies since our times are always in UTC

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 3f43184 into dev May 17, 2023
52 checks passed
@frenck frenck deleted the websocket_sign_path branch May 17, 2023 20:01
rlippmann pushed a commit to rlippmann/core that referenced this pull request May 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants