New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lookin falling back to polling too quickly #93227
Conversation
If the meteo sensor was quiet, we would fallback to polling to quickly because the integration would prematurely believe push updates were no longer working
Hey there @ANMalko, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Tested overnight and updates still coming in as expected 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
It may be worth considering defining the NEVER_TIME
constant alongside the others, since future changes could lead to unexpected behavior. Or possibly a sanity check to ensure that POLLING_FALLBACK_SECONDS > -NEVER_TIME
Thanks. I moved the constant in 8cd954f |
retest is good |
Proposed change
If the meteo sensor was quiet, we would fallback to polling to quickly because the integration would
prematurely believe push updates were no longer working
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: