Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lookin falling back to polling too quickly #93227

Merged
merged 3 commits into from May 20, 2023
Merged

Fix lookin falling back to polling too quickly #93227

merged 3 commits into from May 20, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 18, 2023

Proposed change

If the meteo sensor was quiet, we would fallback to polling to quickly because the integration would
prematurely believe push updates were no longer working

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

If the meteo sensor was quiet, we would fallback to
polling to quickly because the integration would
prematurely believe push updates were no longer working
@home-assistant
Copy link

Hey there @ANMalko, mind taking a look at this pull request as it has been labeled with an integration (lookin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lookin can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lookin Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco marked this pull request as ready for review May 18, 2023 15:33
@bdraco
Copy link
Member Author

bdraco commented May 18, 2023

Tested overnight and updates still coming in as expected 👍

@bdraco bdraco changed the title Fix lookin falling back to polling to quickly Fix lookin falling back to polling too quickly May 18, 2023
Copy link
Contributor

@Noltari Noltari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It may be worth considering defining the NEVER_TIME constant alongside the others, since future changes could lead to unexpected behavior. Or possibly a sanity check to ensure that POLLING_FALLBACK_SECONDS > -NEVER_TIME

@bdraco
Copy link
Member Author

bdraco commented May 20, 2023

Thanks. I moved the constant in 8cd954f

@bdraco
Copy link
Member Author

bdraco commented May 20, 2023

retest is good

@bdraco bdraco merged commit fc7a421 into dev May 20, 2023
24 checks passed
@bdraco bdraco deleted the lookin_poll branch May 20, 2023 19:41
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants