Support HassTurnOn/Off intents for lock domain

[tetele]

Breaking change

No

Proposed change

HassTurnOn/HassTurnOff intents were used for domains which had dedicated intents (e.g. cover - HassOpenCover). For the lock domain, there was no "translation" of intents to the proper lock services - lock.lock and lock.unlock.

This PR addresses this issue and fixes home-assistant/intents#1347

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Unexpected error with lock intent intents#1347, "lock <lock>" Assist intent doesn't work with some locks #97941
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (intent) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of intent can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign intent Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[tetele]

There were no tests for the similar but already handled issue for the cover domain. Should I add tests for both?

[synesthesiam]

For binary sensor locks, they have:

lock: on means open (unlocked), off means closed (locked)

Shouldn't we follow suit here?

[tetele]

That's fair, but the intents are defined (and most likely translated) differently:

• https://github.com/home-assistant/intents/blob/main/sentences/en/lock_HassTurnOn.yaml
• https://github.com/home-assistant/intents/blob/main/sentences/en/lock_HassTurnOff.yaml

Let me know what you want to do

[tetele]

I think the best solution is to switch the contents and intent names of the 2 lock_HassTurnXx files, but I'm concerned about the tests in the intents repo. I don't think I want to tackle that issue myself :)

[clearwave1]

This was reported back in May and still is not fixed? Can someone please move this forward?

[Maxcodesthings]

@synesthesiam can you help move this forward? All checks are passing

[HNKNTA]

Hello everyone, please review and merge this, not having working locks really sucks.

[synesthesiam]

Thank you so much! Sorry for the delay.

[MartinHjelmare]

Please address the comment in a new PR. Thanks!

[MartinHjelmare]

Ternary operator expressions that span more than one line are really hard to read. I suggest defining a local variable above first and use that here.