Bugfix and add test coverage for zwave_js.light #93257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: zwave_js
small-pr
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
emontnemery
requested changes
May 22, 2023
There was a problem hiding this comment.
The PR title does not match the description, can you clarify it @raman325 ?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
raman325
changed the title
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
May 22, 2023
…fig_parameter * 'dev' of https://github.com/home-assistant/core: (390 commits) Use snapshots in devolo_home_control tests (home-assistant#93202) Configurable KNX Telegram history size (home-assistant#93248) Bugfix and add test coverage for zwave_js.light (home-assistant#93257) Refactor zwave_js.fan and add tests (home-assistant#93256) Bugfix and small refactor for zwave_js.device_action (home-assistant#93261) Refactor zwave_js.sensor and add test coverage (home-assistant#93259) Improve test coverage for zwave_js.trigger (home-assistant#93260) Fix august configuration url with Yale Home brand (home-assistant#93361) Make mqtt device_tracker state_topic optional when json_attribute_topic is used (home-assistant#93322) Move HydrawiseEntity into entity.py (home-assistant#93359) Update Home Assistant base image to 2023.05.0 (home-assistant#93350) Adjust counter to not restore configuration parameters (home-assistant#93344) Deprecate counter.configure service (home-assistant#93343) Update zwave-me-ws version to 0.4.3 (home-assistant#93348) Add myself as a code owner of the Hydrawise integration (home-assistant#93358) Move Hydrawise constants into const.py (home-assistant#93357) Improve test coverage for zwave_js (home-assistant#93262) Add advanced imap option to set custom event max message size (home-assistant#93163) Bump zwave-js-server-python to 0.48.1 (home-assistant#93342) Bump `aionotion` to 2023.05.5 (home-assistant#93334) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
ZwaveBlackIsOffLightto only set the colors to turn on the light if colors are sent in the service call. I'm not sure if this is actually causing issues but at a minimum the code is improvedType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: