Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rising sensor to sun #93276

Merged
merged 3 commits into from Oct 10, 2023
Merged

Conversation

sheldonip
Copy link
Contributor

@sheldonip sheldonip commented May 19, 2023

Proposed change

As mentioned in the issue (#91580), this adds a rising sensor to sun

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant

This comment was marked as resolved.

@home-assistant
Copy link

Hey there @Swamp-Ig, mind taking a look at this pull request as it has been labeled with an integration (sun) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sun can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sun Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

Hi @sheldonip

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@sheldonip sheldonip marked this pull request as ready for review May 19, 2023 13:40
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have tests for all sensors provided by the sun integration, can we add this one?

@home-assistant home-assistant bot marked this pull request as draft May 21, 2023 20:43
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@emontnemery emontnemery changed the title Show rising attribute Add rising sensor to sun May 22, 2023
@home-assistant

This comment was marked as resolved.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @sheldonip 👋

There is a merge conflict on this PR. Could you take a look?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft October 9, 2023 09:56
Signed-off-by: Sheldon Ip <4224778+sheldonip@users.noreply.github.com>
@sheldonip
Copy link
Contributor Author

I have rebased my branch to the latest dev and caught up the new attribute. The latest commit SHA is cfcc85a
Thanks

@sheldonip sheldonip reopened this Oct 9, 2023
@sheldonip sheldonip marked this pull request as ready for review October 9, 2023 21:30
@home-assistant home-assistant bot requested a review from frenck October 9, 2023 21:30
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks fine 👍

Thanks, @sheldonip 👍

../Frenck

@frenck frenck merged commit 6c65db2 into home-assistant:dev Oct 10, 2023
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sun Rising sensor missing
4 participants