New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rising sensor to sun #93276
Add rising sensor to sun #93276
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hey there @Swamp-Ig, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
a00f596
to
fafc54b
Compare
Hi @sheldonip It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently have tests for all sensors provided by the sun integration, can we add this one?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
fafc54b
to
1da7d60
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1da7d60
to
20c335e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @sheldonip 👋
There is a merge conflict on this PR. Could you take a look?
Thanks! 👍
../Frenck
Signed-off-by: Sheldon Ip <4224778+sheldonip@users.noreply.github.com>
20c335e
to
a21990f
Compare
I have rebased my branch to the latest dev and caught up the new attribute. The latest commit SHA is cfcc85a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed change
As mentioned in the issue (#91580), this adds a rising sensor to sun
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: