New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump accuweather
to version 1.0.0
#93305
Conversation
await self.accuweather.async_get_daily_forecast() | ||
if self.forecast | ||
else {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid the use of a multi-line ternary, in those cases using a normal if/else construct is much more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This made me realize that forecast
is not a dict but a list of dicts. Hmm... mypy didn't complain about it.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bieniu 👍
../Frenck
Breaking change
Proposed change
This PR bumps
accuweather
library to version1.0.0
.Calculation of
native precipitation
andprecipitation probability
is not needed now, the value is taken directly from the API data.Changelog: bieniu/accuweather@0.5.2...1.0.0
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: