Improve http handler performance #93324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Predetermine how to run the handler instead of every time - Make hass a closure variable to avoid the lookup each time - Offload the bytes/text conversions to aiohttp since it already handles it
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @Tho85, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bdraco
commented
May 21, 2023
Comment on lines
+141
to
+150
| DescriptionXmlView(config).register(hass, app, app.router) | ||
| HueUsernameView().register(hass, app, app.router) | ||
| HueConfigView(config).register(hass, app, app.router) | ||
| HueUnauthorizedUser().register(hass, app, app.router) | ||
| HueAllLightsStateView(config).register(hass, app, app.router) | ||
| HueOneLightStateView(config).register(hass, app, app.router) | ||
| HueOneLightChangeView(config).register(hass, app, app.router) | ||
| HueAllGroupsStateView(config).register(hass, app, app.router) | ||
| HueGroupView(config).register(hass, app, app.router) | ||
| HueFullStateView(config).register(hass, app, app.router) |
There was a problem hiding this comment.
This is all legacy. This really should be move to a library.
MartinHjelmare
approved these changes
May 21, 2023
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
asyncio.iscoroutinefunctionevery time) -- This is effectively the same thing we do inHassJobto eliminate this call every time since it does an expensive inspect under the hood.Almost every request has to go through here, which means almost any improvement here will speed up every request.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: