Refactor zwave_js.cover

[raman325]

Proposed change

In this PR we:

• Improved test coverage for the cover platform
• Don't assume constants for open and close values and use min and max instead
• Use constants in tests
• Refactor logic into mixins that will make the Window Covering CC PR much simpler to write

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[jbouwh]

Can you split the refactoring and test coverage parts in separate PR's, and start with the coverage PR. This will help us to avoid introducing new regressions due while refactoring.

[raman325]

For tests do you mean the switch to constants? I only added an additional test case, everything else changed in the tests is just a conversion to a constant. I specifically avoided updating existing tests to avoid a possible regression

[jbouwh]

For tests do you mean the switch to constants? I only added an additional test case, everything else changed in the tests is just a conversion to a constant. I specifically avoided updating existing tests to avoid a possible regression

I mean to separate the added tests. The new tests should also work with the current code base.
The constants can be added with the second PR, or in a separate PR.
It makes it easier to review.

[jbouwh]

I think we should rebase and first merge #93458

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[jbouwh]

Now the tests have been merged we should rebase rerun the CI tests.

[jbouwh]

Looks good thnx @raman325 !