Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readable paired device names for Apple TV airplay and companion protocols #93449

Merged
merged 2 commits into from May 25, 2023

Conversation

michalmo
Copy link
Contributor

Proposed change

When an Apple TV is paired an entry is created under Settings -> Remotes and Devices -> Remote App and Devices of the device. Previously the name of this entry was "Living Room" for paired Companion protocol and "Unknown" for AirPlay, which is a bit confusing. A change I made to pyatv (postlund/pyatv#1908) allows customizing this device name, and since this dependency was recently included in Home Assistant (#93172) the paired devices will now use the default "pyatv" name.

This PR sets the paired name to "Home Assistant" to make it super clear what is paired. This will not change existing pairings.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi @michalmo

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of apple_tv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign apple_tv Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@postlund
Copy link
Contributor

Fine by me 👍

@bdraco
Copy link
Member

bdraco commented May 25, 2023

codecov is still being flakey

---------- coverage: platform darwin, python 3.11.3-final-0 ----------
Name                                               Stmts   Miss  Cover   Missing
--------------------------------------------------------------------------------
homeassistant/components/apple_tv/config_flow.py     281      0   100%
homeassistant/components/apple_tv/const.py             4      0   100%
--------------------------------------------------------------------------------
TOTAL                                                285      0   100%

checked locally 👍

@bdraco
Copy link
Member

bdraco commented May 25, 2023

Thanks @michalmo @postlund

@bdraco bdraco merged commit 33387bf into home-assistant:dev May 25, 2023
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants