New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate timer start optional duration parameter #93471
Deprecate timer start optional duration parameter #93471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link to where it was decided to remove the duration parameter or provide the rationale in the PR description
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a merge conflict, could you take a look?
e421970
to
36a4763
Compare
@frenck Conflicts fixed |
65e1a7c
to
9bd83c9
Compare
9a47fef
to
fc83cc8
Compare
fc83cc8
to
bf5107f
Compare
3aafbf9
to
61654a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gjohansson-ST 👍
Proposed change
Start deprecation of optional duration parameter for
start
service call (changes configuration).It brings this integration in a weird place, where the configuration is overridden and stored/restored based on state restore; overriding YAML and the storage.
Also done for other similar helpers, example #93343
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: