Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LaMetric Config Flow for SKY #93483

Merged
merged 6 commits into from Jun 1, 2023
Merged

Conversation

spyfly
Copy link
Contributor

@spyfly spyfly commented May 24, 2023

Proposed change

Fixes the configuration flow for LaMetric SKY

Adds a check for the model type and disables the notification sound for the SKY ("sa5") in the configuration flow.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi @spyfly

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @robbiet480, @frenck, @bachya, mind taking a look at this pull request as it has been labeled with an integration (lametric) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lametric can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lametric Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant home-assistant bot marked this pull request as draft May 24, 2023 18:56
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to add tests for this (which is required for config_flows).

../Frenck

@epenet epenet changed the title Fix Setup Config Flow for LaMetric SKY Fix LaMetric Config Flow for SKY May 24, 2023
@spyfly spyfly force-pushed the lametric_sky branch 3 times, most recently from be5d9fb to e7680f5 Compare May 24, 2023 21:41
@spyfly spyfly marked this pull request as ready for review May 24, 2023 21:41
@home-assistant home-assistant bot requested a review from frenck May 24, 2023 21:41
@spyfly
Copy link
Contributor Author

spyfly commented May 24, 2023

Please make sure to add tests for this (which is required for config_flows).

../Frenck

Added two test cases, one for the TIME and one for the SKY ("sa5")

tests/components/lametric/conftest.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 25, 2023 05:57
@spyfly spyfly marked this pull request as ready for review May 26, 2023 11:29
@home-assistant home-assistant bot requested a review from frenck May 26, 2023 11:29
@spyfly
Copy link
Contributor Author

spyfly commented May 26, 2023

@frenck Added a separate fixture for the SKY 👍

tests/components/lametric/conftest.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 1, 2023 11:22
@spyfly spyfly marked this pull request as ready for review June 1, 2023 12:49
@home-assistant home-assistant bot requested a review from frenck June 1, 2023 12:49
@frenck frenck added this to the 2023.6.0 milestone Jun 1, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @spyfly 👍

../Frenck

@frenck frenck merged commit a260c11 into home-assistant:dev Jun 1, 2023
24 checks passed
balloob pushed a commit that referenced this pull request Jun 1, 2023
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
@spyfly spyfly deleted the lametric_sky branch June 6, 2023 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LaMetric SKY not supported
5 participants