Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support volume level push updates in apple_tv integration #93496

Merged
merged 2 commits into from May 24, 2023

Conversation

michalmo
Copy link
Contributor

Proposed change

Allows the volume level of apple_tv integration media players to update in real time, perfect for automating volume sync across devices.

Pyatv 0.12.0 adds support for push updates of the device volume level. This PR updates the pyatv dependency and adds the required code to use this feature.

changelog: postlund/pyatv@v0.11.0...v0.12.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of apple_tv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign apple_tv Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@jbouwh
Copy link
Contributor

jbouwh commented May 24, 2023

Can you add PR to update the docs?
https://www.home-assistant.io/integrations/apple_tv/

@michalmo
Copy link
Contributor Author

Can you add PR to update the docs?
https://www.home-assistant.io/integrations/apple_tv/

@jbouwh I've read that page, but I don't really see anything extra to add there. The current state of the integration is that volume level updates only after another event occurs (power state change or playback state change), with this change the entity state updates as soon as volume is changed. Did you have a specific change in mind?

@jbouwh
Copy link
Contributor

jbouwh commented May 24, 2023

Did you have a specific change in mind?

Not directly. It was just a check. CI tests will be fixed soon.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testing now

bdraco

This comment was marked as duplicate.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a home pod mini.

Asked siri to increase volume and new state was reflected almost immediately

@bdraco
Copy link
Member

bdraco commented May 24, 2023

Thanks @michalmo @postlund

@bdraco bdraco merged commit d5e09bd into home-assistant:dev May 24, 2023
52 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants