New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support volume level push updates in apple_tv integration #93496
Conversation
Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Can you add PR to update the docs? |
@jbouwh I've read that page, but I don't really see anything extra to add there. The current state of the integration is that volume level updates only after another event occurs (power state change or playback state change), with this change the entity state updates as soon as volume is changed. Did you have a specific change in mind? |
Not directly. It was just a check. CI tests will be fixed soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, testing now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with a home pod mini.
Asked siri to increase volume and new state was reflected almost immediately
Proposed change
Allows the volume level of apple_tv integration media players to update in real time, perfect for automating volume sync across devices.
Pyatv 0.12.0 adds support for push updates of the device volume level. This PR updates the pyatv dependency and adds the required code to use this feature.
changelog: postlund/pyatv@v0.11.0...v0.12.0
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: