Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sensor tests to avoid patching utcnow #93497

Merged
merged 4 commits into from May 25, 2023
Merged

Update sensor tests to avoid patching utcnow #93497

merged 4 commits into from May 25, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 24, 2023

Proposed change

Update sensor tests to avoid patching utcnow

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensor can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sensor Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco mentioned this pull request May 24, 2023
20 tasks
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Thnx @bdraco! 👍

@bdraco
Copy link
Member Author

bdraco commented May 24, 2023

thanks. I thought I had them all but I missed some of the stats tests #93499

@bdraco
Copy link
Member Author

bdraco commented May 24, 2023

That sensor test test_compile_statistics_hourly_daily_monthly_summary was on the edge of taking too long and now its over

@bdraco
Copy link
Member Author

bdraco commented May 24, 2023

I had to move the freeze context around the functions that generates lots of states to make it fast enough not to fail

@bdraco
Copy link
Member Author

bdraco commented May 24, 2023

This is probably easier to see the change without whitespace since all the context manager wrapping needed indent changes

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,
Thanx @bdraco 💯

@bdraco
Copy link
Member Author

bdraco commented May 24, 2023

0.46s locally but still to slow for github

@bdraco
Copy link
Member Author

bdraco commented May 24, 2023

We should probably refactor some of these tests to be async since the jumps back and forth to the event loop to set the states are more expensive than the db work in some cases.

But that's for another PR

@bdraco bdraco merged commit 7ec6e03 into dev May 25, 2023
48 checks passed
@bdraco bdraco deleted the sensor_freeze_time branch May 25, 2023 00:54
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants