New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sensor tests to avoid patching utcnow #93497
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good,
Thnx @bdraco! 👍
thanks. I thought I had them all but I missed some of the stats tests #93499 |
That sensor test |
I had to move the freeze context around the functions that generates lots of states to make it fast enough not to fail |
This is probably easier to see the change without whitespace since all the context manager wrapping needed indent changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice,
Thanx @bdraco 💯
0.46s locally but still to slow for github |
We should probably refactor some of these tests to be async since the jumps back and forth to the event loop to set the states are more expensive than the db work in some cases. But that's for another PR |
Proposed change
Update sensor tests to avoid patching utcnow
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: