Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark as assumed_state LG Netcast media player #93543

Merged
merged 1 commit into from May 25, 2023

Conversation

Drafteed
Copy link
Contributor

@Drafteed Drafteed commented May 25, 2023

Breaking change

LG Netcast media player do no longer have fake (assumed) playing or paused states and those are replaced with the on state. You need to update your automation if you are using play or pause states.

Proposed change

Since the LG Netcast devices do not provide playback status, this change marks the media player as assumed_state. This will separate play/pause buttons in the UI and get rid of cases when the play/pause button had to be pressed twice to take effect, since the real state of the TV could be differ with assumed in the integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label May 25, 2023
@thecode
Copy link
Member

thecode commented May 25, 2023

Thanks!

@thecode thecode merged commit 70e2081 into home-assistant:dev May 25, 2023
19 checks passed
@Drafteed Drafteed deleted the lg_netcast-assumed-state branch May 25, 2023 19:47
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change by-code-owner cla-signed integration: lg_netcast Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants