Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qbittorrent YAML configuration #93548

Merged
merged 1 commit into from Jun 5, 2023

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented May 25, 2023

Breaking change

Configuring qBittorrent via YAML was deprecated in Home Assistant Core 2023.5 and support has now been removed.
The YAML configuration was automatically imported to a config entry by release Home Assistant Core 2023.5. Please remove qBittorrent YAML configuration from your configuration.yaml file.

Proposed change

Remove platform yaml qbittorrent, deprecation started in 2023.5 and is now ended after 2 releases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @geoffreylagaisse, mind taking a look at this pull request as it has been labeled with an integration (qbittorrent) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of qbittorrent can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign qbittorrent Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@gjohansson-ST gjohansson-ST marked this pull request as draft May 25, 2023 19:17
@emontnemery emontnemery changed the title Remove platform yaml qbittorrent Remove qbittorrent YAML configuration May 26, 2023
@mvdwetering
Copy link
Contributor

fyi, the title mentions qbittorrent but the breaking changes section mentions snapcast.

@chrisx8 chrisx8 mentioned this pull request Jun 5, 2023
19 tasks
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are we waiting for anything?

@chrisx8
Copy link
Contributor

chrisx8 commented Jun 5, 2023

@MartinHjelmare Seems like it's just a typo in the PR description.

@MartinHjelmare
Copy link
Member

That's been edited I think.

@gjohansson-ST
Copy link
Member Author

@MartinHjelmare actually the config entry was merged just after the .4 release so it wasn't part until .5 release hence I set this as draft so it's not breaking until .7 e.g. 2 releases.

But now beta has come out so we can move on. Same for #93547

@gjohansson-ST gjohansson-ST marked this pull request as ready for review June 5, 2023 16:13
@gjohansson-ST gjohansson-ST merged commit d9ac041 into home-assistant:dev Jun 5, 2023
24 checks passed
@gjohansson-ST gjohansson-ST deleted the qbittorrent branch June 5, 2023 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants