Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obihai YAMl configuration #93549

Merged
merged 2 commits into from May 26, 2023

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented May 25, 2023

Breaking change

Configuring Obihai via YAML was deprecated in Home Assistant Core 2023.4 and support has now been removed.
The YAML configuration was automatically imported to a config entry by release Home Assistant Core 2023.4 ~ 5. Please remove Obihai YAML configuration from your configuration.yaml file.

Proposed change

Remove platform yaml obihai, deprecation started in 2023.4 and is now ended after 2 releases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dshokouhi, @ejpenney, mind taking a look at this pull request as it has been labeled with an integration (obihai) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of obihai can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign obihai Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@gjohansson-ST gjohansson-ST added the smash Indicator this PR is close to finish for merging or closing label May 25, 2023
@ejpenney
Copy link
Contributor

Except for the one comment, this looks exactly like the branch I had prepared for this :)

https://github.com/ejpenney/core/tree/ejpenney_obihai_yaml_deprecation

We can go ahead and use yours since it's more up-to-date!

Thanks!

@emontnemery emontnemery changed the title Remove platform yaml obihai Remove obihai YAMl configuration May 26, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gjohansson-ST 👍

../Frenck

@frenck frenck merged commit af9ee8b into home-assistant:dev May 26, 2023
24 checks passed
@gjohansson-ST gjohansson-ST deleted the obihai-platform-yaml-remove branch May 26, 2023 06:42
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change cla-signed has-tests integration: obihai Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants