Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise issue "does not support platform setup" #93585

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions homeassistant/components/alarm_control_panel/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/binary_sensor/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -314,5 +314,11 @@
"smoke": "smoke",
"sound": "sound",
"vibration": "vibration"
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/button/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,11 @@
"update": {
"name": "Update"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/calendar/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/camera/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/climate/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,5 +103,11 @@
"temperature": { "name": "Target temperature" }
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/cover/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,11 @@
"window": {
"name": "Window"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/date/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,11 @@
"_": {
"name": "[%key:component::date::title%]"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/device_tracker/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/fan/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/humidifier/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,11 @@
"humidifier": {
"name": "[%key:component::humidifier::entity_component::_::name%]"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/light/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,5 +86,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/lock/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/media_player/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -159,5 +159,11 @@
"receiver": {
"name": "Receiver"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/number/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -154,5 +154,11 @@
"wind_speed": {
"name": "[%key:component::sensor::entity_component::wind_speed::name%]"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/remote/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,11 @@
"on": "[%key:common::state::on%]"
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/select/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/sensor/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -267,5 +267,11 @@
"wind_speed": {
"name": "Wind speed"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/siren/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/switch/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,11 @@
"outlet": {
"name": "Outlet"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/text/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/time/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,11 @@
"_": {
"name": "[%key:component::time::title%]"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/update/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,11 @@
"firmware": {
"name": "firmware"
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/vacuum/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,11 @@
"returning": "Returning to dock"
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/water_heater/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,11 @@
"performance": "Performance"
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
6 changes: 6 additions & 0 deletions homeassistant/components/weather/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,11 @@
}
}
}
},
"issues": {
"platform_integration_no_support": {
"title": "[%key:common::issues::platform_integration_no_support_title%]",
"description": "[%key:common::issues::platform_integration_no_support_description%]"
}
}
}
14 changes: 14 additions & 0 deletions homeassistant/helpers/entity_platform.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
from .device_registry import DeviceRegistry
from .entity_registry import EntityRegistry, RegistryEntryDisabler, RegistryEntryHider
from .event import async_call_later, async_track_time_interval
from .issue_registry import IssueSeverity, async_create_issue
from .typing import ConfigType, DiscoveryInfoType

if TYPE_CHECKING:
Expand Down Expand Up @@ -209,6 +210,19 @@ async def async_setup(
self.platform_name,
self.domain,
)
async_create_issue(
self.hass,
self.domain,
f"platform_integration_no_support_{self.domain}_{self.platform_name}",
is_fixable=False,
severity=IssueSeverity.ERROR,
translation_key="platform_integration_no_support",
translation_placeholders={
"domain": self.domain,
"platform": self.platform_name,
},
)

return

@callback
Expand Down
4 changes: 4 additions & 0 deletions homeassistant/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@
"unknown_authorize_url_generation": "Unknown error generating an authorize URL.",
"cloud_not_connected": "Not connected to Home Assistant Cloud."
}
},
"issues": {
"platform_integration_no_support_title": "Platform support not supported",
"platform_integration_no_support_description": "The {platform} platform for the {domain} integration does not support platform setup.\n\nPlease remove it from your configuration and restart Home Assistant to fix this issue."
}
}
}
11 changes: 10 additions & 1 deletion tests/helpers/test_entity_platform.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
device_registry as dr,
entity_platform,
entity_registry as er,
issue_registry as ir,
)
from homeassistant.helpers.entity import (
DeviceInfo,
Expand Down Expand Up @@ -1355,7 +1356,9 @@ async def test_override_restored_entities(


async def test_platform_with_no_setup(
hass: HomeAssistant, caplog: pytest.LogCaptureFixture
hass: HomeAssistant,
caplog: pytest.LogCaptureFixture,
issue_registry: ir.IssueRegistry,
) -> None:
"""Test setting up a platform that does not support setup."""
entity_platform = MockEntityPlatform(
Expand All @@ -1368,6 +1371,12 @@ async def test_platform_with_no_setup(
"The mock-platform platform for the mock-integration integration does not support platform setup."
in caplog.text
)
issue = issue_registry.async_get_issue(
domain="mock-integration",
issue_id="platform_integration_no_support_mock-integration_mock-platform",
)
assert issue
assert issue.translation_key == "platform_integration_no_support"


async def test_platforms_sharing_services(hass: HomeAssistant) -> None:
Expand Down