Subscribe to device registry changes from entities #93601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
emontnemery
force-pushed
the
entity_listen_device_updates
branch
from
61b5684
to
7f99b75
Compare
bdraco
reviewed
May 30, 2023
homeassistant/helpers/entity.py
Outdated
Comment on lines
332
to
334
| if not self._attr_name: | ||
| return True | ||
| return False |
There was a problem hiding this comment.
Suggested change
| if not self._attr_name: | |
| return True | |
| return False | |
| return not self._attr_name |
bdraco
reviewed
May 30, 2023
homeassistant/helpers/entity.py
Outdated
Comment on lines
342
to
344
| if not self.entity_description.name: | ||
| return True | ||
| return False |
There was a problem hiding this comment.
Suggested change
| if not self.entity_description.name: | |
| return True | |
| return False | |
| return not self.entity_description.name |
bdraco
reviewed
May 30, 2023
homeassistant/helpers/entity.py
Outdated
Comment on lines
346
to
349
| if not self.name: | ||
| return True | ||
|
|
||
| return False |
There was a problem hiding this comment.
Suggested change
| if not self.name: | |
| return True | |
| return False | |
| return not self.name |
|
testing performance now |
bdraco
reviewed
May 30, 2023
homeassistant/helpers/entity.py
Outdated
Comment on lines
351
to
359
| def _name_translation_key(self) -> str | None: | ||
| """Return translation key for entity name.""" | ||
| if self.translation_key is None: | ||
| return None | ||
| assert self.platform | ||
| return ( | ||
| f"component.{self.platform.platform_name}.entity.{self.platform.domain}" | ||
| f".{self.translation_key}.name" | ||
| ) |
There was a problem hiding this comment.
Can this change? should we cache it?
|
startup performance looks good testing run time now the entity registry subscribes are so much higher on the list. I cleaned that up in #93823 |
bdraco
added a commit
that referenced
this pull request
May 30, 2023
noticed in #93601 that the cost of creating the function in the closure was a bit expensive since we do it once per entity
20 tasks
20 tasks
bdraco
added a commit
that referenced
this pull request
May 30, 2023
While reviewing #93601 it was noticed this was slow at startup #93601 (comment) This is a first pass attempt to improve the performance
|
Runtime performance looks good 👍 |
bdraco
approved these changes
May 30, 2023
balloob
pushed a commit
that referenced
this pull request
May 31, 2023
* Use ReadOnlyDict for entity registry options While reviewing #93601 it was noticed this was slow at startup #93601 (comment) This is a first pass attempt to improve the performance * fix tests
balloob
pushed a commit
that referenced
this pull request
May 31, 2023
noticed in #93601 that the cost of creating the function in the closure was a bit expensive since we do it once per entity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Subscribe to device registry changes from entities which don't have their own name
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: