Add Ezviz siren entity #93612
Merged
Add Ezviz siren entity #93612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @BaQs, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
|
Final remarks. Please undraft when ready. |
gjohansson-ST
requested changes
Aug 10, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
gjohansson-ST
requested changes
Aug 13, 2023
| self.coordinator.ezviz_client.sound_alarm, self._serial, 2 | ||
| ): | ||
| self._attr_is_on = True | ||
| evt.async_call_later(self.hass, OFF_DELAY, self.off_delay_listener) |
There was a problem hiding this comment.
What if someone press turn on 30 seconds after the first on press?
Still going to turn off after the first 60 seconds or should you get a new 60 seconds?
There was a problem hiding this comment.
I see it resets, have added logic to reset the event.
Thanks for asking.
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
gjohansson-ST
approved these changes
Aug 13, 2023
h3l1o5
pushed a commit
to h3l1o5/ha_core
that referenced
this pull request
Aug 14, 2023
* Initial commit * Add siren entity * Update coveragerc * Cleanup unused entity description. * Add restore and fix entity property to standards. * Schedule turn off to match camera firmware * Only add siren for devices that support capability * Removed unused attribute and import. * Add translation * Update camera.py * Update strings.json * Update camera.py * Cleanup * Update homeassistant/components/ezviz/siren.py Co-authored-by: G Johansson <goran.johansson@shiftit.se> * use description * Apply suggestions from code review Co-authored-by: G Johansson <goran.johansson@shiftit.se> * Update strings.json * Dont inherit coordinator class. * Add assumed state * Update homeassistant/components/ezviz/siren.py Co-authored-by: G Johansson <goran.johansson@shiftit.se> * Reset delay listener if trigered --------- Co-authored-by: G Johansson <goran.johansson@shiftit.se>
| ir.async_create_issue( | ||
| self.hass, | ||
| DOMAIN, | ||
| "service_depreciation_sound_alarm", |
| self.async_write_ha_state() | ||
|
|
||
| @callback | ||
| def off_delay_listener(self, now: datetime) -> None: |
There was a problem hiding this comment.
We don't allow calculating state in Home Assistant for device integrating integrations. The device should update its state. Please move the update to the 3rd party library.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add Ezviz siren entity.
EZVIZ calls this "Active Defence" and it could be a combination of Siren + Strobe or just a Strobe on some cameras.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: