New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Roborock Clean time sensors #93637
Conversation
Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@allenporter thought I'd let you know I have a new set of Roborock PRs up. Didn't know if you want me to ping you when I have some up or not. I won't in the future if you don't want me to, just let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at roomba and tuya and they call this Cleaning time
. In addition to consistency, i think they are also easier names to understand what this is.
Optional suggestion: The tuya icons are nice since they picked a different icon for the total that may make it more clear that it's referring to the historical total time.
Optional suggestion: Consider if you want to opt these into [long term statistics](I looked at roomba and tuya and they call this Cleaning time
.)
Yes, that's fine , i am interested. ( Though i think other core maintainers don't necessarily do this). If you are able to 'request review" that works too. |
Yeah I don't think it is normal, I just know you said you have a Roborock yourself. I only want to do it if it is something you are interested in and it is not an inconvenience. I am not able to request review. |
Breaking change
Proposed change
Adds both total clean time and 'current/last' clean time sensors.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: