Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roborock Clean time sensors #93637

Merged
merged 4 commits into from May 29, 2023

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented May 27, 2023

Breaking change

Proposed change

Adds both total clean time and 'current/last' clean time sensors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@Lash-L
Copy link
Contributor Author

Lash-L commented May 29, 2023

@allenporter thought I'd let you know I have a new set of Roborock PRs up.

Didn't know if you want me to ping you when I have some up or not. I won't in the future if you don't want me to, just let me know!

@allenporter allenporter self-requested a review May 29, 2023 14:38
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at roomba and tuya and they call this Cleaning time. In addition to consistency, i think they are also easier names to understand what this is.

Optional suggestion: The tuya icons are nice since they picked a different icon for the total that may make it more clear that it's referring to the historical total time.
Optional suggestion: Consider if you want to opt these into [long term statistics](I looked at roomba and tuya and they call this Cleaning time.)

@allenporter
Copy link
Contributor

allenporter commented May 29, 2023

@allenporter thought I'd let you know I have a new set of Roborock PRs up.

Didn't know if you want me to ping you when I have some up or not. I won't in the future if you don't want me to, just let me know!

Yes, that's fine , i am interested. ( Though i think other core maintainers don't necessarily do this). If you are able to 'request review" that works too.

@Lash-L Lash-L requested a review from allenporter May 29, 2023 15:03
@Lash-L
Copy link
Contributor Author

Lash-L commented May 29, 2023

Yes, that's fine , i am interested. ( Though i think other core maintainers don't necessarily do this). If you are able to 'request review" that works too.

Yeah I don't think it is normal, I just know you said you have a Roborock yourself. I only want to do it if it is something you are interested in and it is not an inconvenience. I am not able to request review.

The other two I have open right now are: #93636 and #93633

@allenporter allenporter merged commit 3b4273d into home-assistant:dev May 29, 2023
24 checks passed
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label May 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed has-tests integration: roborock new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants