Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video id to youtube sensor state attributes #93668

Merged
merged 4 commits into from Jun 1, 2023

Conversation

joostlek
Copy link
Member

Proposed change

Add video id to state attributes so it can be used in automations

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

frenck
frenck previously requested changes May 29, 2023
homeassistant/components/youtube/sensor.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 29, 2023 19:43
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek marked this pull request as ready for review May 29, 2023 21:09
@home-assistant home-assistant bot requested a review from frenck May 29, 2023 21:09
@frenck
Copy link
Member

frenck commented May 29, 2023

@joostlek I'm sorry, I've seriously misread your PR, it was correct originally.

Could you revert d2f9e93?

Sorry about this 🙏

../Frenck

@frenck frenck marked this pull request as draft May 29, 2023 21:17
@joostlek joostlek marked this pull request as ready for review May 29, 2023 21:22
@joostlek
Copy link
Member Author

Can we make this in the June release? With this change you can actually use the sensor to do automations :)

@frenck
Copy link
Member

frenck commented Jun 1, 2023

Can we make this in the June release?

We can't anymore at this point. The beta has been cut.

@emontnemery emontnemery changed the title Add video id to state attributes Add video id to youtube sensor state attributes Jun 1, 2023
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @joostlek 👍

@emontnemery emontnemery dismissed frenck’s stale review June 1, 2023 09:46

The requested change has been implemented (and reverted)

@emontnemery emontnemery merged commit a6b6b03 into home-assistant:dev Jun 1, 2023
24 checks passed
@joostlek joostlek deleted the youtube_video_id branch June 1, 2023 10:06
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
@balloob balloob added this to the 2023.6.0 milestone Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants